583/Use REST api to retrieve chapter image #587
Conversation
| return isDefault; | ||
| } | ||
|
|
||
| public void setUrl(String url) { |
There was a problem hiding this comment.
I would be safer to delete these setters. I guess you are not using them.
| } | ||
|
|
||
| private void loadChapterImageInto(String gplusId, ImageView groupLogo) { | ||
| App.getInstance().getPlusApi().getImageInfo(gplusId).enqueue(new retrofit2.Callback<ImageInfo>() { |
There was a problem hiding this comment.
You should use our Callback. If you use this, necessary things like idlingResources won't happen.
There was a problem hiding this comment.
@tasomaniac In https://github.com/gdg-x/frisbee/blob/583/anonymous_chapter_image/app/src/main/java/org/gdg/frisbee/android/api/PlusApiFactory.java#L18 there is the idlingResources configuration. Is that enough?
There was a problem hiding this comment.
Your are right, but the reason is Timber logging, not idlingResources
There was a problem hiding this comment.
That's where idlingResources are registered. And then when the request is finished, they need to be released. We are using our Callback everywhere. So, if we use this here, it will make problems later.
|
👍 |
583/Use REST api to retrieve chapter image
This PR adds a retrofit service for the Google plus REST API.
It is used to retrieve chapter images in the event details page.