Addresses Issue #29 with 502 401 exception fixes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r HTTP exceptions
gdgib
previously approved these changes
Apr 4, 2024
cayossarian
dismissed
gdgib’s stale review
The merge-base changed after approval.
gdgib
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #29. The previous code erroneously raised an authentication exception when a gateway 502 problem was experienced by transient network problems, e.g., firmware updates.
Tested this fix by providing bad auth token and received a proper log error about authentication and the integration stopped as expected.
Tested this fix by blocking calls to the integration on the network and received a proper log entry regarding API could not be called via any means. After the network was restored the integration worked as expected without any intervention.