Addresses Issue #45 - 500 error on abort in config dialog for auth method #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r HTTP exceptions
…_choose_auth_type as expected by HA Core when an abort occurs as that method will be called again with a user_input value of None. This allows the previous step sto signal that it is calling async_step_choose_auth_type by passing an empty dictionary instead of None
cayossarian
dismissed
gdgib’s stale review
The merge-base changed after approval.
gdgib
previously approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #45. Added the required second parameter user_input to the async_step_choose_auth_type method so when HA core calls this method after an abort from the dialog the dialog can understand the abort occurred. Also passed in an empty dictionary from the previous step to signal that the start of the step is configuration driven and not an abort.