Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request command to toggle "Disable for once" #113

Closed
ww7 opened this issue Jan 30, 2020 · 8 comments
Closed

Request command to toggle "Disable for once" #113

ww7 opened this issue Jan 30, 2020 · 8 comments
Labels
question

Comments

@ww7
Copy link

ww7 commented Jan 30, 2020 •
edited
Loading

Web applications often use keyboard shortcuts. Command for toggle Vimium-C would be helpful.
@gdh1995
Copy link
Owner

gdh1995 commented Jan 30, 2020 via email •
edited
Loading

@ww7
Copy link
Author

ww7 commented Jan 30, 2020 •
edited
Loading

thanks!, both works
map Z openUrl url="vimium://status\u0020toggle"
map i enterInsertMode

@gdh1995
Copy link
Owner

gdh1995 commented Jan 30, 2020 •
edited
Loading

Um, the content from mail looks too ugly, so I've updated.

If map Z openUrl url="vimium://status\u0020toggle", then Z will turn off Vimium C "totally", so you will have no shortcut to re-enable it. For this issue, there's an advanced usage: map Z openUrl url="vimium://status toggle ^ Z", and then Z can always be used to toggle status.

Note that the sub-string of "^" and " " before Z is necessary, to ensure a user know this usage. I once forgot it when I wrote the mail above.

BTW, enterInsertMode only applies on a current iframe, and vimium://status toggle will take effects on all frames of a current tab.

@gdh1995 gdh1995 closed this as completed Jan 31, 2020
@gdh1995
Copy link
Owner

gdh1995 commented Feb 1, 2020

Oops, on v1.80.1 released yesterday, the usage of toggle ^ Z still works, but toggle ^ <f7> breaks...

@gdh1995 gdh1995 reopened this Feb 1, 2020
gdh1995 added a commit that referenced this issue Feb 1, 2020
@gdh1995
exclusion keys: fix a bug
fbc5fc3 
see #113 (comment)
@ww7
Copy link
Author

ww7 commented Feb 1, 2020

I'm tried map Z openUrl url="vimium://status toggle ^ Z" – for me it's only disable or enable once, not toggle (macos Firefox)
It's should works with Shift+Z in toggle mode?

@gdh1995
Copy link
Owner

gdh1995 commented Feb 1, 2020 via email

@gdh1995
Copy link
Owner

gdh1995 commented Feb 2, 2020 •
edited
Loading

Sorry, after a new test, I found the usage has been totally broken...

Z will be translated into z, so only map z openUrl url="vimium://status toggle ^ z works, but a lower-case key is not suitable in daily use...

I'm fixing it. And it seems a new version is urgent.

Here's a test version for this issue: vimium_c-1.80.1-fx-3962e51.zip

gdh1995 added a commit that referenced this issue Feb 2, 2020
@gdh1995
fix bugs when converting URLs
3962e51 
* `abcdef.` should mean a search text
* `oldString` should ignore the double quotes
  * `"vimium://***"` should not be treated as vimium URLs
* `vimium://status` should not be converted to lower-case ones so early

This may solve
#113 (comment) .
@gdh1995
Copy link
Owner

gdh1995 commented Feb 9, 2020

V1.80.2 has been published on Firefox Add-ons, and you may have a try.

@gdh1995 gdh1995 closed this as completed Feb 14, 2020
@gdh1995 gdh1995 mentioned this issue Feb 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gdh1995 @ww7