Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimium-c + Midnight Lizard = delay in scrolling on some websites #175

Closed
maciejmotyka opened this issue May 19, 2020 · 7 comments
Closed
Labels

Comments

@maciejmotyka
Copy link

I recently switched from philc/vimium and was positively surprised by Vimium C. One negative thing that I've noticed was a noticeable delay between pressing j or k and the onset of scrolling on some of the pages, e.g. amazon.com or youtube.com. The majority of other websites didn't have this issue.
I did some detective work and tracked it down to a bad synergy with the Midnight Lizard extension.

To reproduce:

Note: the delay occurs even when Midnight Lizard is set to not change the theme of the website, i.e. the extension is enabled but not changing the website look at that moment.

That situation is very unfortunate 😢 . Midnight Lizard is a 5 star extension with 40k+ users, and Vimium C seems to be better than the original. For now, I'm going back to philc/vimium.
Tagging @Midnight-Lizard just in case.

OS: Ubuntu MATE 20.04
Browsers: Vivaldi 3.0.1874.38, Chrome 81.0.4044.138
Extensions: Vimium C 1.83.1, Midnight Lizard 10.5.0

@gdh1995 gdh1995 added the bug label May 20, 2020
@gdh1995
Copy link
Owner

gdh1995 commented May 20, 2020

Thanks for this report. A work-around is to add options to scroll* commands, like:

map j scrollDown keepHover
map k scrollUp keepHover

The keepHover option tells Vimium C not to modify page styles, so that the browser responses quicker.

detalied analysis

This is because:

  • Amazon has tons of CSS rules and JS code
  • Midnight Lizard adds some CSS rules
  • Vimium C tries to add a new CSS rule on beginning to scroll
    • this new rule, with the impact of those Midnight Lizard's, causes Chrome executes a very heavy task
    • then the first scrolling effect gets delayed

On my computer, this process takes 40ms on amazon and with the M-L extension disabled, while requires as much as 150ms (sometimes 200ms) with M-L enabled.

@maciejmotyka
Copy link
Author

It works. Thank you!

Is there any downside of using keepHover? Am I sacrificing some functionality?

@gdh1995
Copy link
Owner

gdh1995 commented May 20, 2020 via email

@Monirzadeh
Copy link

side note: @maciejmotyka chrome has flag Force Dark Mode for Web Contents i get better result and performance compare to Midnight-Lizard

@maciejmotyka
Copy link
Author

Thank you both! Closing.

gdh1995 added a commit that referenced this issue May 23, 2020
@gdh1995
Copy link
Owner

gdh1995 commented May 23, 2020

Hello, you may try this: vimium_c-1.83.2-chrome-9041514.zip, vimium_c-1.83.2-firefox-9041514.zip.

keepHover has been default to true.

Install:

  • unzip a zip file into an empty folder
  • if on Chrome, open chrome://extensions/ and enable the "developer mode"
  • if on Firefox, open about:debugging#/runtime/this-firefox manually
  • click the "load extension" button and select the extension folder or manifest.json

@maciejmotyka
Copy link
Author

Tested in Vivaldi, on amazon.com - works fine. Occasionally the scroll pauses for few milliseconds, when some hover effect gets triggered, but this is a minor inconvenience compared to the original issue. I will report if I encounter pages that have hover effects that cause bad scrolling experience.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants