visitPreviousTab feature request

[tirphana]

What command or commands

visitPreviousTab

How should a feature do

When a user has done such steps:

1. Open three new tabs, regardless the URL
2. Discard the one that was opened last using "Auto Tab Discard" or any other similar addon
3. The focus jumps to the tab that was opened second, now execute Vimium's visitPreviousTab command

then Vimium C should do:

1. Jump to the tab that was opened first, and is still active. But, by default it jumps to (and refreshes) the third one, which is indeed the one previously used. However, during regular usage I find that discarding a tab is in a sense almost equivalent to closing it, and it would be much better if discarded tabs would be treated as such by this command, instead of refreshing them.

Browser and OS

• Browser name: Firefox 89.0.2, Vimium 1.92.4
• OS name: Arch Linux

[gdh1995]

Sorry, I'm not sure whether I've understood what you said or not. Let me give what I got: * 3 tabs named A, B and C * visit A, visit B and visit C * go to B, and discard C * trigger visitPreviousTab * it should go to A, but up to now it's C Am I right? If so, then I accept this and it will be a new option of this command, like: map xxx visitPreviousTab filter="discarded=false"

…

---Original--- From: ***@***.***> Date: Thu, Aug 26, 2021 22:17 PM To: ***@***.***>; Cc: ***@***.***>; Subject: [gdh1995/vimium-c] visitPreviousTab feature request (#416) What command or commands visitPreviousTab How should a feature do When a user has done such steps: Open three new tabs, regardless the URL Discard the one that was opened last using "Auto Tab Discard" or any other similar addon The focus jumps to the tab that was opened second, now execute Vimium's visitPreviousTab command then Vimium C should do: Jump to the tab that was opened first, and is still active. But, by default it jumps to (and refreshes) the third one, which is indeed the one previously used. However, during regular usage I find that discarding a tab is in a sense almost equivalent to closing it, and it would be much better if discarded tabs would be treated as such by this command, instead of refreshing them. Browser and OS Browser name: Firefox 89.0.2, Vimium 1.92.4 OS name: Arch Linux — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[tirphana]

That's exactly right, it should visit the previous non-discarded tab, which is A in this case you mentioned. I assume it would be available on the next update then?

[gdh1995]

Hello, you may take a try with Vimium C v1.96.3 on Firefox Add-Ons, which has fixed some bugs about filter, and then visitPreviousTab filter="discarded=false" should work.

[tirphana]

Yaaay, it works now, thank you for implementing this! 👍