-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vomni bar font customization #43
Comments
Um, are the current Chinese fonts affecting the apparance of non-Chinese characters? If not, then you may not need to remove them, because font-missing has very, very, very low performance impact. |
No it does not affect. It just not a standard font that is commonly seen in English speaking website. Most common fonts on english speaking sites would be something like I think having a toggle switch between Chinese font and the default font of Vimium in non-advance setting would be nice to have. So that users wouldnt have to deal with CSS at all (Back End/ Low level programmer dread CSS)
|
Sorry but I can't get what you really want. Basically:
So for a web page, its CSS styles are (almost always) not changed, unless a user enters FindMode - in FindMode, Vimium C will try to make a page selectable if needed. I've searched in the code, and the only places having Chinese fonts are: 1. Vomnibar's titles of suggestions, 2. and Vimium C Options page. |
Yes! I was not making this clearer but this was a complain about Vomnibar's font Now that I inspected it closer, my annoyance was with the different font you used for the bottom(Consolas) vs the top part(Helvetica) I will just fix it in my CSS setting to force the bottom one to use the same font as the top part. |
Oh, the different fonts is on purpose. I want Vimium C to support Chinese page titles by default, so set the font; while usually a URL has no Chinese characters, so for As for the "Consolas" fonts, it's because as a programmer, I'm used to watch and read fixed-width fonts. |
This is quite subjective, while browsing web, its a reading experience, not coding. I have worked in Chinese company and I understand the attractiveness of Consolas but it makes English words more 'spreaded' out and a bit hard to read for me. I am looking for a way to override this font setting with CSS and seems like this is not available. Only option is to point to my own hmm |
Um, the I'll explain how to custom Vomnibar's CSS on Vimium C's Options page after a while. |
You need to modify the " /* #omni */
.top, a {
font-family: "Helvetica Neue",Helvetica,Arial,sans-serif;
} Added note: the |
You're right. It is indeed a problem. So, maybe I'll add an option (in the advanced boolean options area) to toggle the default fonts for URLs. |
I am trying /* #omni */
.bottom, a {
font-family: '"Helvetica Neue",Helvetica,Arial,sans-serif';
} on firefox and it does not work. Manual inspect and modify the CSS definitely not seeing it having any affected in the CSS inside the shadow root. |
You add two extra |
Hmm it was just a result of me experimenting around since the original approach was not working. I reproduce on a blank tab "Vimium C New Tab" with to trigger Omni Bar and the .bottom class font is always the same. Not sure if Firefox is an issue? Gona try this on Chrome tomorrow |
Um, what version of Vimium C are you using? The customized styles would be added to If still can not see it, maybe I need to upgrade Vimium C on Firefox Add-ons. |
hmm im on Inside the i can see 2 <style> tag: the default one and the id="dark" one. No A search for |
Sorry this feature of customized CSS does break on Firefox when Vimium C's version is v1.74.9, I'll push a new version. |
With the version 1.75.3 of Vimium C, just modify The old example value of |
Worked with Firefox + VimiumC ver 1.75.3 /* #omni */
.bottom, a {
font-family: "Helvetica Neue",Helvetica,Arial,sans-serif;
} and {
"maxMatches": 10,
"queryInterval": 500,
"styles": "dark"
} |
@gdh1995 How do I make the omnibar bigger? I have successfully increased the font size using
But it looks bad (things are crowded together, I want the height to be more): I played a bit with |
The default CSS is in After that, to make JavaScript code of Vomnibar understand your new height values, you can modify the |
请问下要怎么将最上面的搜索框的高度调大(能给个例子不),下面的items我知道怎么调大,但最上面的不知道为啥不行。 |
Hey I really enjoy using this project.
Please consider provide some out-of-the-box option for standard font configuration as non-chinese user will not need to use the Chinese dedicated fonts.
(I know i can override it with CSS, but having an one click button would be nice)
Thanks.
The text was updated successfully, but these errors were encountered: