Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot iterate twitter images in Firefox #559

Closed
leodream opened this issue Feb 25, 2022 · 12 comments
Closed

Cannot iterate twitter images in Firefox #559

leodream opened this issue Feb 25, 2022 · 12 comments
Labels

Comments

@leodream
Copy link

Describe the bug

Cannot select the next/previous images with [[/]] when viewing a tweet that has multiple images in Firefox

To Reproduce

Steps to reproduce the behavior:

  1. Open a tweet with multiple images. (e.g. https://twitter.com/firefox/status/1461436801093193738)
  2. Click on one image. There are "→" and "←" shown at the edge of the images.
  3. With Firefox, [[ and ]] do not work. With Chrome, it can change to next and previous images.

Browser, OS and Vimium C versions

  • Browser name: Firefox
  • Browser version: 97.0.1
  • Vimium C version: 1.96.6
  • OS name and version: openSUSE Tumbleweed Linux 5.16.10-1
@gdh1995
Copy link
Owner

gdh1995 commented Feb 25, 2022

Does your Firefox has a same configuation for the preferred page language with your Chrome?

Twitter doesn't provide enough clues to let Vimium C know the arrow icons mean "next/previous" (for web-extension code, there's no way to check whether an icon "looks like arrow" or not).

The only useful point is title of the 2 icons. So during my tests, on twitter in English goNext works, but it fails when the page is in Chinese.

@leodream
Copy link
Author

Thanks for the response.

Confirmed that

  • the preferred language is set to English in both browser setting and the twitter account setting
  • tried with incognito/private mode (without login to twitter), same behavior

Twitter doesn't provide enough clues to let Vimium C know the arrow icons mean "next/previous" (for web-extension code, there's no way to check whether an icon "looks like arrow" or not).

Indeed, I was surprised when I first noticed [[]] worked in that page using Chrome.

The only useful point is title of the 2 icons. So during my tests, on twitter in English goNext works, but it fails when the page is in Chinese.

I cannot find any goNext from the F12 console of that page, and still cannot get [[]] work after adding goNext to the "Next Patterns" configuration in Firefox.

@gdh1995
Copy link
Owner

gdh1995 commented Feb 25, 2022

Um, the goNext above means the Vimium C command.

The title goNext will use is [aria-label], and I wonder what it is on your Chrome and Firefox:
image

@leodream
Copy link
Author

Both shows "Previous slide".
chrome:
chrome

firefox:
firefox

Also checked with newly installed Firefox on Windows, same result -- looks like it has nothing to do with platform and other addons.

@gdh1995
Copy link
Owner

gdh1995 commented Feb 25, 2022

Okay, I'll take a try in days.

@gdh1995 gdh1995 added bug and removed enhancement labels Feb 25, 2022
gdh1995 added a commit that referenced this issue Mar 6, 2022
* update `nextPatterns`
* and exclude those with `[aria-haspopup]`

for #559
@gdh1995
Copy link
Owner

gdh1995 commented Mar 22, 2022

Hello Vimium C v1.97.0 has been published on Firefox Add-ons, and you may take a try.

@leodream
Copy link
Author

The issue persists on Vimium C [1.97.0] Firefox 98, Linux.

@gdh1995
Copy link
Owner

gdh1995 commented Apr 23, 2022

hello, v1.98.0 has been released, and you may take a try.

@gdh1995
Copy link
Owner

gdh1995 commented Jun 9, 2022

Hello, Vimium C v1.98.2 for Firefox has been published, and you may take a try.

@leodream
Copy link
Author

Both Chrome and Firefox cannot go to the next image with "]]" with 1.98.2

@gdh1995
Copy link
Owner

gdh1995 commented Aug 10, 2022

Hello, I added some new logic in Vimium C v1.99.0 to solve twitter images support, and up to now the version has been available on Firefox Add-Ons, so you may take a try on Firefox.

@leodream
Copy link
Author

Works perfectly. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants