Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow loading on sourcegraph pages with big files #751

Closed
sluongng opened this issue Oct 13, 2022 · 3 comments
Closed

Slow loading on sourcegraph pages with big files #751

sluongng opened this issue Oct 13, 2022 · 3 comments

Comments

@sluongng
Copy link

Describe the bug

File load very slowly with vimium-c enable vs without.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://sourcegraph.com/github.com/bazelbuild/remote-apis@aa29b91f336b9be2c5370297210b67a6654c0b72/-/blob/build/bazel/remote/execution/v2/remote_execution.pb.go?L55
  2. Try to scroll on the file with / without Vimium-C enabled.

Browser, OS and Vimium C versions

  • Browser name: Chrome
  • Browser version: Version 106.0.5249.103 (Official Build) (x86_64)
  • Vimium C version: 1.99.3
  • OS name and version: MacOS latest
Google Chrome | 106.0.5249.103 (Official Build) (x86_64)
-- | --
Revision | 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS | macOS Version 12.6 (Build 21G115)

Here is a profiling of the page
image

and tracing into the "Timer Fired" stacks showed that it's from Vimium-C minified JS. Disabling Vimium-C and the issue is gone.

@gdh1995
Copy link
Owner

gdh1995 commented Oct 13, 2022

Confirmed and it can be fixed in a future version.

@gdh1995
Copy link
Owner

gdh1995 commented Oct 13, 2022

If you accept a zip package to test, you may try this: vimium-c-1.99.3-dev-chrome.zip, though the way the version works around this issue is not perfect.

It's because [].indexOf.call(HTMLCollection, Element) in content/extend_click.ts:386 runs too slow, and the page injects much more click listeners than it needs.

gdh1995 added a commit that referenced this issue Oct 16, 2022
@gdh1995
Copy link
Owner

gdh1995 commented Nov 23, 2022

Hello, v1.99.90 has been released on Chrome Web Store, and you may take a try.

@gdh1995 gdh1995 closed this as completed Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants