Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAPTER: Points #28

Closed
darribas opened this issue Jun 30, 2019 · 6 comments
Closed

CHAPTER: Points #28

darribas opened this issue Jun 30, 2019 · 6 comments

Comments

@darribas
Copy link
Member

Issue set up to track "Chapter 9: Point Pattern Analysis"

@darribas darribas added chapter needs review needs internal review from a core author labels Jun 30, 2019
@darribas darribas assigned ljwolf and unassigned sjsrey Dec 13, 2019
@ljwolf
Copy link
Member

ljwolf commented Dec 13, 2019

todo:

  • move airports geoprocessing stuff out to the relevant geoprocessing chapter
  • add centrography on tokyo data
  • add statistical testing on tokyo data

This was referenced Dec 20, 2019
@ljwolf ljwolf mentioned this issue Mar 27, 2020
4 tasks
@ljwolf
Copy link
Member

ljwolf commented May 8, 2020

Need to:

  1. rewrite for the performant numpy-oriented API (few changes)
  2. add questions

@ljwolf ljwolf added the needs questions this chapter needs end of chapter questions label Sep 18, 2020
@darribas darribas assigned darribas and unassigned ljwolf Nov 24, 2020
@darribas
Copy link
Member Author

Review is being coordinated over at #135

@darribas
Copy link
Member Author

darribas commented Jan 26, 2021

Comments from the review, to discuss:

  • We use one function, once that requires OpenCV, which is a pretty hefty install. Could we consider removing it?
  • The Centrography and Randomness sections make use of bold font to signify specific techniques. This is useful, but it's also the only case I can think of in the book where we do this. Do we want to keep the pattern across? Do we want to remove it?
  • I have left some of the code cells that are clearly written to be hidden from the reader on, but we should open a new issue to track application of this feature across the book.
  • We originally say we analyse three Ripley's functions, but then we only expose the $G$ and the $F$. Dis we intend to use $K$? Should we include it?

@darribas
Copy link
Member Author

darribas commented Jan 27, 2021

After c088181 , review at #135 ready to be merged by either @sjsrey or @ljwolf

@ljwolf ljwolf added ready for publisher has been revised internally and is ready to send to publisher and removed needs questions this chapter needs end of chapter questions needs review needs internal review from a core author labels Feb 2, 2021
@darribas darribas removed their assignment Jul 9, 2021
@ljwolf ljwolf assigned ljwolf and unassigned sjsrey Nov 30, 2021
@ljwolf ljwolf added final edits and removed ready for publisher has been revised internally and is ready to send to publisher labels Nov 30, 2021
@ljwolf
Copy link
Member

ljwolf commented Nov 30, 2021

Refer to baddeley book for further info on this chapter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants