Initial implementation of important features #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason to drop the API handle at hand when constructing Client instances, as it comes in handy later on.
Create a common base class (ehour.model.Model) for Client and Project classes, prepared for re-use in other classes as well.
The CLI is intended for debug, test and simple lookups by humans. For API access, use the Python API or the eHour REST API directly.
Although the rate belongs to Assignment, when fetching report, no direct reference to assignment is returned, but the rate used is there. So let's just attach it to Hours, where it definitely can come in handy.
Receipt download is supported in API only for now. CLI only shows number of receipts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the features that I expect to use for now.