Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pair Tag Highlighter - Added a color preferences dialog (Issue #545) #940

Open
wants to merge 89 commits into
base: master
Choose a base branch
from

Conversation

PatrickGMM
Copy link
Contributor

Added a preferences dialog that allows the highlight colors and overall color alpha to be changed.

  • Settings are kept in a .conf file
  • Tested on linux mint 19.1 cinnamon, geany 1.35 with gtk2 v2.24 and gtk3 v3.22

Sagar Chalise and others added 6 commits October 11, 2019 10:47
…gurable

When file operations were added to project organizer, the plugin started
showing empty directories in the sidebar because they are useful e.g.
for creating new files inside them. This may be unwanted e.g. in projects
with many directories which are irrelevant to the code.

This patch makes this configurable on a per-project basis.

Fixes geany#881
There is more choice when using icons based on freedesktop icon name
so we can use better icons.
This makes the icons more consistent with the treebrowser plugin. For
expanding/collapsing use go-down/go-up icons which should look similar
to each other (using list-add/list-remove is usually shown as +/- but
with some themes the remove action is shown as a red cross)
overall color alpha to be changed (geany#545)

* Settings are kept in a .conf file
* Tested on linux mint 19.1 cinnamon, geany 1.35
  with gtk2 v2.24 and gtk3 v3.22
@elextr
Copy link
Member

elextr commented Jan 6, 2020

Afraid the CI fail is pair tag highligher.

Also probably good to follow the style of the original code eg f() not f () but this being a plugin its up to the maintainer to enforce (or not :).

@codebrainz
Copy link
Member

strtol() requires including stdlib.h, but you could also use one of the GDK functions such as gdk_rgba_parse() to parse the colour string or expose one of the functions already in Geany to the plugin API and use that.

frlan and others added 18 commits January 19, 2020 09:57
projectorganizer: don't use stock icons
Utilities for Pair Tag Highlighter
This fixes build with recent versions of cppcheck with some plugins
using PLUGIN_VERSION_CHECK() macro, like the latex plugin.
Implementation shamelessly copied over from pkg-config's pkg.m4,
GPLv2+.
Implementation shamelessly copied over from Autoconf's m4sh.m4, GPLv3+.
cppcheck: Set Geany include path for it to find header files
…2-0.99

LIBGIT2_SOVERSION is defined as string literal, e.g. "0.99",
from libgit2-0.99 and beyond. Arithmetic checks against this
variable whill hence fail. This patch switches the checks to
compare against the LIBGIT2_VER_* family, which should be more stable.
Make libgit2 version preprocessor conditionals compatible with libgit…
latex: added feature: indent line in new environment (fixes geany#950)
projectorganizer: Make showing empty directories in the sidebar configurable
frlan and others added 27 commits October 22, 2020 23:00
This fixes a cppcheck 2.2+ confusion about uninitialized widgets array
and also makes the code a bit more readable.
Closes geany#1014.
Not working anymore and statistics are available via https://i18n.geany.org/plugins/ anyway
The ChangeLog is outdated and wasn't updated for years. Translations updates are avaialble via NEWS anyway
…mpiler-warning

PrettyPrinter: Don't try to free const gchar* input_buffer
GeanyVC: Show ellipsis in menu items requiring further user input
…ny_patch_level

Windows installer: ignore patch level version when checking for Geany
GeanyVC: Show ellipsis in menu items requiring further user input (po update)
GeanyVC: Correct the displaying of tooltip for the attach to menubar action
PO: Add Ukrainian translation
Redefining bool causes errors when used together with ie. GCC 10.2.0
Use stdbool.h istead of redefining bool
@PatrickGMM
Copy link
Contributor Author

I see this is pending fixes. Can someone let me know what fixes I need to perform?

@elextr
Copy link
Member

elextr commented Feb 18, 2021

@PatrickGMM as a minimum the PR has conflicts and is not mergable as is, not sure what other fixes, but I guess the plugin maintainer should comment too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet