Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime-interface): split sandbox interface out of runtime-interface #4034

Merged
merged 10 commits into from
Jul 5, 2024

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Jun 26, 2024

Since we hardly can avoid patching sp-externalities due to the requirements of #4017, gtest would get broken after it.

for the explanation: gear-sandbox ( part of gtest's deps ) has runtime-interface as dependency, and runtime-interface will include gear-tasks after merging #4017 ... after a bench of the dependencies stuffs, we have to upload almost all of the substrate dependencies used in gtest which is on the way to hell

This PR trims the usages of runtime-interface in gear-sandbox since it only needs sandbox-interface but not the entire gear-runtime-interface

  • split out sandbox interface from runtime-interface
  • use sandbox interface instead of the entire runtime interface in gear-sandbox
  • patch gear-sandbox-interface in utils/crates-io

@gear-tech/dev

@clearloop clearloop added the A0-pleasereview PR is ready to be reviewed by the team label Jun 26, 2024
Copy link
Member

@ukint-vs ukint-vs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense

@clearloop clearloop merged commit ee798ca into master Jul 5, 2024
10 checks passed
@clearloop clearloop deleted the cl/sandbox-interface branch July 5, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants