libgearman part of #114 Pvs analyze #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons_st&) issue #72
- use nullptr instead of NULL - uniform initialisation
- use nullptr instead of NULL - uniform initialisation
issue #72 PVS error V547
- use nullptr instead of NULL - uniform initialisation
issue #72 PVS V730
- use nullptr instead of NULL - uniform initialisation
- use universal initialisation
- use nullptr instead of NULL - uniform initialisation
|
This all looks good to me. Another t/memcached test failure, but you should be able to get that to pass by restarting that build. |
This was referenced Dec 16, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on
git diff pvs-analyze master -- libgearman