cherry-picking from #114 Pvs analyze part 2 #215
Conversation
- use nullptr instead of NULL - uniform initialisation
|
Use curly brace initialization style in libgearman-server/struct/gearmand.h lines 53-56? |
| server_thread{}, | ||
| id{}, | ||
| lock{} | ||
| //TODO uniform initialisation doesn't help with wakeup_event |
There was a problem hiding this comment.
Unfortunately I can't remember.
There was a problem hiding this comment.
Probably should remove it then.
libgearman-server/struct/gearmand.h
Outdated
| @@ -75,7 +74,7 @@ struct gearmand_st | |||
|
|
|||
| void keepalive_idle(int keepalive_idle_) | |||
| { | |||
| _keepalive= true; | |||
| keepalive(1); | |||
There was a problem hiding this comment.
Is _keepalive= true bad coding style according to PVS? It should be more efficient than keepalive(1) unless the compiler can optimize it.
There was a problem hiding this comment.
the commit with the changes is removed
|
Should libgearman-server/struct/thread.h line 64 have curly braces after |
- use nullptr instead of NULL - uniform initialisation
- uniform initialisation - nullptr
p-alik
force-pushed
the
pvs-analyze-part2
branch
from
277fff5
to
d34fd50
Compare
I guess the compiler disliked |
Improving of test coverage could help, I think. |
please, review.