Implement Get Channel Cipher Suites command #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the `Get Channel Cipher Suites` command and a function to get proper Cipher Suite for authentication in new session. Currently implementation prefer Cipher Suite 17 and fall back to Cipher Suite 3. Reference: section 22.15, IPMI v2.0 Signed-off-by: Dong, Xiaocheng <xiaocheng.dong@intel.com>
|
Hello @gebn, I implemented the Get Channel Cipher Suites command for gebn/bmc_exporter#63 and #50, please help review this patch, thanks! |
|
Thanks @dongx1x! I've merged your commit and made a handful of wider changes on top - in particular a breaking API change to /cc @lukeyeager - this should also free you from manually configuring cipher suite 17, do let me know if it doesn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
Get Channel Cipher Suitescommand and a function to getproper Cipher Suite for authentication in new session. Currently
implementation prefer Cipher Suite 17 and fall back to Cipher Suite 3.
Reference: section 22.15, IPMI v2.0
Signed-off-by: Dong, Xiaocheng xiaocheng.dong@intel.com