Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix of fdk_convert_lsm #60

Merged
merged 14 commits into from
Sep 5, 2023
Merged

Bugfix of fdk_convert_lsm #60

merged 14 commits into from
Sep 5, 2023

Conversation

stineb
Copy link
Contributor

@stineb stineb commented Sep 4, 2023

Using {lubridate} creates time objects that can be safely joined.
Solves #58

@stineb
Copy link
Contributor Author

stineb commented Sep 5, 2023

This pull request contains several changes made to create an updated driver object for P-model runs with rsofun and other changes, see commit messages. In addition, note the following:

  • I managed to make the bugfix for fdk_convert_lsm() only using {lubridate}. Added to dependencies now.
  • Daytime variable aggregation for temperature and VPD is based using only half-hourly data for time steps when solar radiation is above the 1% quantile of all solar radiation data.
  • Removed reliance on functions fdk_collect_drivers() for creating the driver object and ingestr::ingest() for reading from FLUXNET-standard CSV file.
  • Aggregation to daily is done with mean(..., na.rm = FALSE), not mean(..., na.rm = TRUE) to avoid the problem of uneven missing half-hourly data.
  • Missing net radiation imputation is done with KNN using the {recipes} package. A solution with base-R would be appreciated but I went forward with the option that worked best for me now. Unfortunately, I've had to add the {recipes} package as a dependency.

@khufkens khufkens merged commit 77f2d97 into geco-bern:main Sep 5, 2023
1 check passed
@stineb stineb mentioned this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants