Bug in soilmstress

[davidorme]

Hi,

There is a bug in soilmstress at the line:
https://github.com/computationales/rpmodel/blob/master/R/subroutines.R#L124

The problem only arises if a user provides soilm as a scalar but meanalpha as an array. That's an odd thing to want to do, but might arise if someone wants to see how the stress factor changes for a given soil moisture in different sites.

In this case - in the nested ifelse statements - the first test 'iterates' over the comparison of the single scalar soilm to x1. If meanalpha is an array, the output is therefore either 1 or the first element only of the no argument:

Browse[2]> ifelse(test = 2 > 4, yes = 1, no = runif(10))                                                                                                                         
[1] 0.5927906

A bit obscure, I admit!