Adding a clearer error message when trying to use an invalid includes. #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the error was this: ``` TypeError: Cannot read property 'model' of undefined at utils.mixin._createSelectStatement ``` Now it is this: ``` Error: Could not find the associated model "BadAssociation" on the "GoodModel" model. at utils.mixin._createSelectStatement ``` Test added as well.
|
As you can probably tell by all my pull requests; I keep doing things incorrectly! 👅 |
mde
added a commit
that referenced
this pull request
Feb 15, 2014
Adding a clearer error message when trying to use an invalid includes.
|
This is great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the error was this:
Now it is this:
Test added as well.