Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discriminator Goal #23

Closed
renswny opened this issue Jun 13, 2018 · 1 comment
Closed

Discriminator Goal #23

renswny opened this issue Jun 13, 2018 · 1 comment

Comments

@renswny
Copy link

renswny commented Jun 13, 2018

Is the discriminator's goal to determine relevant vs. non-relevant query-document pairs, or true vs. generated query-document pairs? If the former is true, shouldn't the stopping criteria for IRGAN be the discriminator converging to 1 (relevant) everywhere, instead of 0.5? If the latter is true, shouldn't the generator perform positive sampling instead of negative sampling in order to fool the discriminator? Thanks in advance for the clarification!

@wnzhang
Copy link
Collaborator

wnzhang commented Jun 14, 2018

The discriminator tries to detect whether a query-doc pair is from true data distribution or the generated one, not about the (non)-relevancy. The generator tries to create a CONDITIONAL distribution of documents given the user's query P(d|q;theta), thus when such a distribution perfectly fits the true preference distribution P_data(d|q), the discriminator cannot distinguish whether a query-doc pair is from P(d|q;theta) or P_data(d|q). Thus the prediction of D should be 0.5 instead of 1.0.

@wnzhang wnzhang closed this as completed Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants