Fix test generation #775
Merged
Fix test generation #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arnaudgelas
commented
Jan 18, 2024
arnaudgelas
commented
- Stop generating unit tests for non-python code files (e.g. ReadMe.md)
- Stop trying to install dependencies when there are none
arnaudgelas
had a problem deploying
to
unittest
GitHub Actions
Failure
geekan
reviewed
Jan 19, 2024
When trying to create a simple HelloWorld with test, metagpt creates test for README.md
Do not try running pip install -r requirements.txt if the file does not exist or is empty. It avoids seeing an error in the log.
arnaudgelas
force-pushed
the
fix/test-generation
branch
from
c5c6e09
to
6a9bd4a
Compare
arnaudgelas
had a problem deploying
to
unittest
GitHub Actions
Failure
|
While the improvement in test coverage is lacking here, it does provide meaningful logic |
|
@arnaudgelas If the PR is marked as draft, then it cannot be merged |
|
Won't this impact non-python unit testing, such as Javascript/Typescript? |
geekan
approved these changes
Jan 23, 2024
|
@apofic Yes. This means that there will be missing tests for other languages. Perhaps we need a complete solution, but currently I'm not sure if it exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.