Added header functionality to send method in __init__.py #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeknam
approved these changes
May 12, 2017
|
Please update the failing unit test. |
|
Hey I'm not sure how to do that. If you can give me some help, I'd be happy
to contribute. I'm pretty inexperienced.
…On Fri, May 12, 2017 at 4:46 PM Nam Ngo ***@***.***> wrote:
Please update the failing unit test.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZHwvPwLG6kLpk-QpWytKRZPdfQW-jzkks5r5O9qgaJpZM4NY_ua>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Facebook Messenger API requires this header for json content. This package wasn't fully functional for me in all cases without this header. The current format may be out of date, or simply wrong. In any case, I propose this branch be merged.
Take a look at Facebook's Messenger API documentation for buttons, for example. POST requests are sent with the header
"Content-Type: application/json", which is not part of this package's current formatting.