Stick to defaults - update homebrew_install_path #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the README says - it is recommended to stick to the default. The default install path is /opt/homebrew on macs with Apple-chipsets [1]. 1: <https://github.com/Homebrew/install/blob/master/install.sh#L151-L160>
No reason to create the folder when it isn't needed. Not sure if this is the best solution here, but it's simple.
|
The CI-errors does not seem to be related to the changes I proposed |
|
I've checked the homebrew installation script (https://raw.githubusercontent.com/Homebrew/install/master/install.sh) and @dennisse is correct, the homebrew repository is installed in /opt/homebrew instead of /opt/homebrew/Homebrew, see this line in the official installation script: https://github.com/Homebrew/install/blob/3d2b88baf18424b561766fcdac31be06553e0e07/install.sh#L155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the README says [1], it is recommended to stick to the defaults. The default install path is
/opt/homebrewon macs with Apple-chipsets [2], not/opt/homebrew/Homebrew.1: https://github.com/geerlingguy/ansible-collection-mac/blob/master/roles/homebrew/README.md?plain=1#L20
2: https://github.com/Homebrew/install/blob/master/install.sh#L151-L160
The second commit makes sure
/opt/homebrew/Homebrewisn't created on macs with Apple-chipsets.