Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong variable "php_installed_versionl" #76

Closed
Smurv opened this issue Feb 10, 2016 · 1 comment
Closed

Wrong variable "php_installed_versionl" #76

Smurv opened this issue Feb 10, 2016 · 1 comment

Comments

@Smurv
Copy link

Smurv commented Feb 10, 2016

Hi,

in file " ansible-role-php/tasks/main.yml" on line 48 there is:

shell: '{{ php_executable }} -r "echo php_installed_version;"'

but "php_installed_version" is not PHP variable. It should be "PHP_VERSION":

shell: '{{ php_executable }} -r "echo PHP_VERSION;"'

Sorry, I'm new to github and don't know, how to pull code :-(

Than
@geerlingguy
Copy link
Owner

Thanks for noting this!

ivangrynenko pushed a commit to ivangrynenko/ansible-role-php that referenced this issue Jun 14, 2016
@geerlingguy
Merge pull request geerlingguy#76 from BlackMesh/allow_custom_variables
a3d3bf2 
Allow configuration of variables not currently supported
ivangrynenko pushed a commit to ivangrynenko/ansible-role-php that referenced this issue Jun 14, 2016
@geerlingguy
PR geerlingguy#76 follow-up: Clean up defaults examples.
0c224d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geerlingguy @Smurv