Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(installer): Check if all install dependencies are available #226

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

georgkrause
Copy link
Contributor

No description provided.

@georgkrause georgkrause changed the title feat(installer): Check if all install dependencies are available Draft: feat(installer): Check if all install dependencies are available Oct 27, 2022
@georgkrause
Copy link
Contributor Author

Don't merge yet, there is one problem remaining

@georgkrause georgkrause changed the title Draft: feat(installer): Check if all install dependencies are available feat(installer): Check if all install dependencies are available Oct 27, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@georgkrause
Copy link
Contributor Author

I tested this on a fresh debian image without any tool installed and it works. gefyra version still fails due to a missing git executable, is this something we should add as a check as well?

@SteinRobert
Copy link
Contributor

gefyra version still fails due to a missing git executable, is this something we should add as a check as well?

How come a git executable is needed? Could you please post the error message of gefyra version?

@georgkrause
Copy link
Contributor Author

georgkrause commented Oct 27, 2022

I messed up, this was about Getdeck. I made the same changes there, too.

Anyways, gefyra version also fails:

root@1afbf3060151:/app# gefyra version
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "gefyra.__main__", line 6, in <module>
  File "gefyra.api", line 1, in <module>
  File "gefyra.api.bridge", line 5, in <module>
  File "gefyra.configuration", line 221, in <module>
  File "gefyra.configuration", line 121, in __init__
OSError: [Errno 19] No such device

Edit: This might be just related to running it inside docker

@SteinRobert
Copy link
Contributor

I see. The reason this one fails is probably because there is no docker socket available for communication (which should probably be not needed for the version command anyway). But that's another issue, so I guess we're fine here.

@SteinRobert SteinRobert merged commit 111f279 into gefyrahq:main Oct 28, 2022
@fraVlaca
Copy link

hei sorry, I have the sama exact problem, how do I solve it @SteinRobert ?

@fraVlaca
Copy link

I get
Traceback (most recent call last): File "<string>", line 1, in <module> File "gefyra.__main__", line 6, in <module> File "gefyra.api", line 1, in <module> File "gefyra.api.bridge", line 5, in <module> File "gefyra.configuration", line 233, in <module> File "gefyra.configuration", line 119, in __init__ OSError: [Errno 19] No such device

with any gefyra comand I try...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants