WIP: Fix Krates/cargo_metadata pairing #521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkforest
changed the title
pinkforest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Needs work. There are broken abstractions / couplings between krates/geiger/cargo_metadata
The only way to fix it is to upgrade the deps but that leads to a lot of breaking changes between krates / cargo_metadata which are coupled as internal abstractions that are very time consuming to eradicate and / or fix.
The biggest is cargo_metadata::PackageId is not recognised by krates anymore and the previous versions of krates have some unhandled unwrap that is deep down the parser that handles the repr (that comes from the lockfile)
The release from crates.io works fine but transient dependency messed things up for main dev which is pity.
I'll continue untangling the abstractions that are affected by the breakage in order to upgrade to fix.