Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App usage by Domain and LDAP user added #25

Merged
merged 1 commit into from
Jun 24, 2023
Merged

App usage by Domain and LDAP user added #25

merged 1 commit into from
Jun 24, 2023

Conversation

toafez
Copy link
Contributor

@toafez toafez commented Jun 24, 2023

Hi!
I have modified the index.cgi so that the app can now also be run by Domain and LDAP users. More specifically, I have changed the following:

  • In addition to local DSM users, the app can now be used by Domain and LDAP users.
  • The authentication check whether a local user exists and whether this user is a member of the administrators group has been removed.
  • The internal evaluation as well as the appending of the SynoToken to the QUERY_STRING has been removed, as this is already done by the last implemented iFrame inclusion.

I hope you like it this way and make this available to the community after a thorough review.

toafez

@geimist geimist merged commit 8523d87 into geimist:master Jun 24, 2023
@toafez toafez mentioned this pull request Jul 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geimist geimist geimist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toafez @geimist