Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go further with BSD license #3

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Go further with BSD license #3

merged 4 commits into from
Dec 22, 2022

Conversation

hartwork
Copy link
Collaborator

@hartwork hartwork commented Dec 21, 2022 •
edited

  • Document change of license to 3-clause BSD license (for next release)
  • Apply 3-clause BSD license where visible to the user (at runtime)
  • Update "BSD 3-Clause License" to say "3-Clause BSD License" instead. Seems more suitable to humans and matches display at https://opensource.org/licenses/BSD-3-Clause (minus the "The" in the beginning).

@geissomatik this needs careful review and testing. For review, I recommend looking at each commit individually (rather than the combined diff).

@hartwork hartwork force-pushed the go-further-with-bsd-license branch 2 times, most recently from f150e14 to b37775c Compare December 21, 2022 22:54
@hartwork hartwork added the enhancement New feature or request label Dec 22, 2022
@hartwork
Copy link
Collaborator Author

@geissomatik I caught something while manually testing just now, the text is cut off in practice, see below. I have an idea why that is, let's see if I can fix it…

Screenshot_20221222_141303

@hartwork
Copy link
Collaborator Author

hartwork commented Dec 22, 2022 •
edited

@geissomatik turns out our dear friend wsprintfA has an artificial size limit of 1024 characters on the target buffer… 😄
Looks better now, see below. Also, I returned the leading empty lines in bin_*/geiss_whatsnew.txt that seemed like a previous style choice to me, and rebased against latest main.

Screenshot_20221222_144223

geissomatik
geissomatik approved these changes Dec 22, 2022
View reviewed changes
Copy link
Owner

@geissomatik geissomatik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the 1024-char limit! (yeesh!)

@hartwork hartwork merged commit 1ca05ba into main Dec 22, 2022
@hartwork hartwork deleted the go-further-with-bsd-license branch December 22, 2022 20:24
@hartwork hartwork added this to the 4.30 milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geissomatik geissomatik geissomatik approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.30
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hartwork @geissomatik