Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: manually add references to styled-jsx for rollup ecosystem #681

Merged
merged 3 commits into from
Jan 22, 2022
Merged

build: manually add references to styled-jsx for rollup ecosystem #681

merged 3 commits into from
Jan 22, 2022

Conversation

unix
Copy link
Member

@unix unix commented Jan 22, 2022

Checklist

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Fixed bundle for styled-jsx

When a user build a project with rollup, the styled-jsx is not handled properly, this is a long-standing issue, but there is no good solution on either styled-jsx or rollup.

To make styled-jsx compatible with rollup, we compile it before release and manually fix the issues in it.

  • Test with esbuild solutions such as vite
  • Test with next.js
  • Test with CRA
  • Test with webpack4 / 5
  • Test esm and cjs module references separately
  • Test styles in packaged static content
  • Dynamic styles can be rendered on the server side

@unix unix added type: bug Something isn't working type: chore labels Jan 22, 2022
@unix unix self-assigned this Jan 22, 2022
@unix unix linked an issue Jan 22, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #681 (a607f21) into master (dae1da2) will not change coverage.
The diff coverage is n/a.

❗ Current head a607f21 differs from pull request most recent head ec9dd13. Consider uploading reports for the commit ec9dd13 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #681   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         194      194           
  Lines        2947     2947           
  Branches      672      672           
=======================================
  Hits         2942     2942           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890d083...ec9dd13. Read the comment docs.

@unix unix merged commit fe6baec into geist-org:master Jan 22, 2022
@unix unix deleted the build/styled-jsx branch January 25, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Theme not getting applied.
1 participant