fix: enable passing style attribute to icons
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhoyeo
added a commit
to junhoyeo/junho.io-v2
that referenced
this pull request
Oct 23, 2022
unix
reviewed
Oct 27, 2022
| @@ -65,7 +65,7 @@ const parseSvg = (svg: string, styles: any) => { | |||
| } | |||
|
|
|||
| svg = svg.replace(/-([a-z])(?=[a-z\-]*[=\s/>])/g, g => g[1].toUpperCase()) | |||
| svg = svg.replace(/<svg([^>]+)>/, `<svg$1 {...props} height={size} width={size} style={{color}}>`) | |||
| svg = svg.replace(/<svg([^>]+)>/, `<svg$1 {...props} height={size} width={size} style={{...style,color}}>`) | |||
There was a problem hiding this comment.
Is it necessary to add a default value for style?
{...(style || {})}
There was a problem hiding this comment.
Nullish values are ignored for spread operators, so I don't think it's necessary.
{...undefined}
// {}
{...null}
// {}There was a problem hiding this comment.
Can I have a bump? @unix
There was a problem hiding this comment.
That was fast. Many thanks! 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
styleattributes are ignored because it's been overridden bystyle={{color}}.Changes
color—Now you can pass styles toIcon!