Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Fixed Code Kata Bug #843

Merged
merged 7 commits into from
Oct 15, 2018
Merged

Fixed Code Kata Bug #843

merged 7 commits into from
Oct 15, 2018

Conversation

dboschm
Copy link
Collaborator

@dboschm dboschm commented Oct 11, 2018

Description:

The Code Editor in the student view was not bindet bidirectionally to the "code" Property. So the validation runs an empty string every time.

Closes #834

Improvements

  • Code Kata Validation bug is fixed.

Known Issues:

There are currently two identical code kata validation functions. (one in unit form, the other in unit). #844

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.126%

Totals Coverage Status
Change from base Build 2: 0.0%
Covered Lines: 1711
Relevant Lines: 2235

💛 - Coveralls

@dboschm dboschm changed the title ⚠ WIP: Fixed Code Kata Bug Fixed Code Kata Bug Oct 13, 2018
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

@kesselb
Copy link
Contributor

kesselb commented Oct 15, 2018

geli_834_code_kata

@kesselb kesselb merged commit fdaec95 into develop Oct 15, 2018
@kesselb kesselb deleted the bugfix/#834-Code-Kata branch October 15, 2018 19:06
@dboschm dboschm mentioned this pull request Oct 15, 2018
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Code Kata
3 participants