Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shakemap to GMFs #3545

Merged
merged 39 commits into from
Apr 6, 2018
Merged

Shakemap to GMFs #3545

merged 39 commits into from
Apr 6, 2018

Conversation

micheles
Copy link
Contributor

Part of #3544.

@ptormene ptormene removed the WIP label Mar 28, 2018
@micheles micheles modified the milestones: Engine 3.0.0, Engine 3.1.0 Apr 4, 2018
"""
T = imt.period
if T < 1:
b = 40.7 - 15.0 * T if vs30clustered else 8.5 + 17.2 * T
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a reference to a scientific paper that explains those numbers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vitor says that the article is still in the publishing process, accepted but who knows when it will appear.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the same model that is already implemented here https://github.com/gem/oq-engine/blob/master/openquake/hazardlib/correlation.py#L126 ? If that is the case the scientific paper is Jayaram & Baker (2009) as cited in the doc string of that class.

Any way to get around having two different implementations of the same formula?

@micheles
Copy link
Contributor Author

micheles commented Apr 5, 2018

You are right, Graeme. Now I remember that I wanted to check the correlation matrix in hazardlib but then, busy with the 3.0 release, I forgot to do that. It makes sense to reuse the formula in hazardlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants