Tl16 #4352
Merged
Tl16 #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this need backport to 3.3? @micheles |
|
This is a question for @mmpagani |
|
I don’t think it’s necessary. Recently they run calculation from master.
…On 11 Jan 2019, at 8:20, Michele Simionato wrote:
This is a question for @mmpagani
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#4352 (comment)
|
No, they don't. They are running a "feature frozen" nightly build which is 3.3 in practice, but they must be brought back to stable ASAP (the effort to keep them on unstable is too high, and too risky). |
|
LGTM on my part, if @mmpagani is happy. Please update the changelog. |
mmpagani
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While preparing the new Italian National Hazard model, INGV noticed that some GMPEs in tusa_langer_2016.py mistakenly used frequency values as periods in the coefficient tables. This bug was present in the the epicentral models, but not the hypocentral model.
The values have been corrected in the GMPE file and in the verification tables.