This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Using the same quantile algorithm both for weight=None and not None #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum, I don't understand why you need to change the values into the test. I understood the two algorithms in absence of weights were giving the same results. Also, the original reason for an ad-hoc routine when weight were not defined was calculation efficiency. Did you perhaps check this? |
|
No, the two algorithms in absence of weights were giving DIFFERENT results, hence the problem. There is no performance problem with any algorithm, computing the quantiles is a negligible operation compared to combining the probabilities. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #577