Time brightness #580
Time brightness #580
Conversation
|
Seems reasonable to me. Due to the similarity with time-varying coordinates it will be tempting to abstract out |
| @@ -19,6 +22,7 @@ object BrightnessUnits { | |||
| trait FluxDensityContinuum[+T] | |||
|
|
|||
| type BrightnessMeasure[T] = Measure[BigDecimal] Of Brightness[T] | |||
| type BrightnessMeasureOverTime[T] = NonEmptyMap[Instant, Measure[BigDecimal] Of Brightness[T]] | |||
There was a problem hiding this comment.
I suppose we could use the BrightnessMeasure alias here.
There was a problem hiding this comment.
Sounds like a good idea, to reduce confusion a bit
| final case class EmissionLine[T]( | ||
| lineWidth: Quantity[PosBigDecimal, KilometersPerSecond], | ||
| lineFlux: Measure[PosBigDecimal] Of LineFlux[T] | ||
| lineFlux: EmissionLine.LineFluxOverTime[T] |
There was a problem hiding this comment.
I don't know anything about this unfortunately. It makes sense that the "line flux" would vary but are we sure that it does?
There was a problem hiding this comment.
I'll verify, my input from science is that emission lines can also vary over time
| } | ||
|
|
||
| object EmissionLine { | ||
| implicit def eqEmissionLine[T]: Eq[EmissionLine[T]] = | ||
| type LineFluxOverTime[T] = NonEmptyMap[Instant, Measure[PosBigDecimal] Of LineFlux[T]] |
There was a problem hiding this comment.
I wondered why we don't add a LineFluxMeasure to parallel the BrightnessMeasure.
There was a problem hiding this comment.
Sounds like I just missed it when implementing emission lines. Let's add it.
This is a proposal for adding a time dimension to Magnitudes
Basically it replaces measurement values with
NonEmptyMap[Timestamp, BrightnessMeasure[T]]NonEmptyMapis backed by aSortedMapthus we'd keep the entries in order and we need at least one, signalling the common case where the value is constantThere are a few things missing, like interpolation of values and lenses but wanted to request a first impression on the impact of this change.