Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

Added name to NoRefImageError #361

Merged
merged 1 commit into from
Jan 27, 2016
Merged

Added name to NoRefImageError #361

merged 1 commit into from
Jan 27, 2016

Conversation

SwinX
Copy link
Contributor

@SwinX SwinX commented Jan 26, 2016

No description provided.

@SwinX SwinX self-assigned this Jan 26, 2016
@levonet levonet added the review label Jan 26, 2016
@SwinX
Copy link
Contributor Author

SwinX commented Jan 26, 2016

/cc @sipayRT @j0tunn

@SwinX SwinX mentioned this pull request Jan 26, 2016
Merged
@SevInf
Copy link
Contributor

SevInf commented Jan 26, 2016

Actually, the only reason to have NoRefImageError was now dead referenceImageAbsence option. I think the error now can be just replaced with StateError

@SwinX
Copy link
Contributor Author

SwinX commented Jan 26, 2016

@SevInf No, this specific error needed in gemini-gui in order to implement reference saving feature. So removing is not an option.

@SevInf
Copy link
Contributor

SevInf commented Jan 26, 2016

🆗

@sipayRT
Copy link
Member

sipayRT commented Jan 27, 2016

ok

SwinX added a commit that referenced this pull request Jan 27, 2016
@SwinX
Merge pull request #361 from gemini-testing/no_ref_image_fix
867d187 
Added name to NoRefImageError
@SwinX SwinX merged commit 867d187 into master Jan 27, 2016
@SwinX SwinX deleted the no_ref_image_fix branch January 27, 2016 09:25
@levonet levonet removed the review label Jan 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@SwinX SwinX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SwinX @SevInf @sipayRT @levonet