Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set up package infrastructure #1

Merged
merged 2 commits into from
Dec 21, 2016
Merged

set up package infrastructure #1

merged 2 commits into from
Dec 21, 2016

Conversation

tormozz48
Copy link
Contributor

@arikon
Copy link

arikon commented Dec 17, 2016

👎 for the name

@tormozz48
Copy link
Contributor Author

@rostik404 @DudaGod @sipayRT @eGavr Please give some ideas for package name

@tormozz48
Copy link
Contributor Author

Please choose appropriate name:

  1. sobr (statistic over browser running)
  2. boston
  3. filch (mr. Argus Filch from Harry Potter saga)
  4. your variant

@DudaGod
Copy link
Member

DudaGod commented Dec 19, 2016

Мой вариант - browser-statistics

@SwinX
Copy link

SwinX commented Dec 19, 2016

iconostasis 2.0 же

@tormozz48
Copy link
Contributor Author

Короче brostat и все

@tormozz48
Copy link
Contributor Author

@DudaGod @rostik404 ping

@rostik404
Copy link

Предлагаю browstat

@eGavr
Copy link

eGavr commented Dec 19, 2016

а че не назвать stat-reporter ?

ну это же по факту отдельный репортер, не?

@rostik404
Copy link

rostik404 commented Dec 19, 2016 •
edited
Loading

а че не назвать stat-reporter ?

Вот, это уже ближе! Или например, browsers-reporter

@eGavr
Copy link

eGavr commented Dec 19, 2016

мне вообще не принципиально как он будет называться, хоть brostatit, лишь бы работал хорошо и был полезен.

@tormozz48
Copy link
Contributor Author

ну это же по факту отдельный репортер, не?

в самом плагине может быть несколько репортеров

@tormozz48
Copy link
Contributor Author

@rostik404 @DudaGod переименовал плагин в stat-reporter. Может уже пора поревьюить?

DudaGod
DudaGod reviewed Dec 21, 2016
View reviewed changes
README.md
@@ -0,0 +1,2 @@
# stat-reporter
Плагин для gemini и hermione, который позволяет выводить статистику о пройденных тестах для каждого из браузеров
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а почему не по английски?

package.json
@@ -0,0 +1,55 @@
{
"name": "stat-reporter",
"version": "1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ты же вроде всегда 0.0.1 пускал первой версией

@DudaGod
Copy link
Member

DudaGod commented Dec 21, 2016

в остальном /ok

sipayRT
sipayRT reviewed Dec 21, 2016
View reviewed changes
package.json
"browser",
"stat",
"statistic",
"console",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

сеошник, блин)
кажется, что console и html тут лишние

@sipayRT
Copy link
Member

sipayRT commented Dec 21, 2016

в остальном ok

@tormozz48 tormozz48 merged commit 0e8a649 into master Dec 21, 2016
@tormozz48 tormozz48 deleted the infra branch December 21, 2016 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sipayRT sipayRT sipayRT left review comments

@DudaGod DudaGod DudaGod left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tormozz48 @arikon @DudaGod @SwinX @rostik404 @eGavr @sipayRT