Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config validation and parse cli #13

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Conversation

Dmitriy-kiselyov
Copy link
Contributor

No description provided.

Copy link

@rostik404 rostik404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь тоже непонятный дифф в package-lock, я бы избавился от него. И так же нужно тесты дописать на парсинг cli

lib/config.js Outdated
const argv = process.argv;

return getParser()({options, env, argv});
const isRequestedType = (name, func, type) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func -> validationFn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants