fix: do not lose "testXReqId" when using "parallelLimit" #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
force-pushed
the
HERMIONE-1336.fix_empty_x_req_id
branch
from
ee0ad97
to
6c277e6
Compare
DudaGod
commented
Jan 30, 2024
| const pool = await makePool_({ limit: 1 }); | ||
| await pool.getBrowser("bro", { some: "opt1" }); | ||
| // should be called without await | ||
| Promise.delay(100).then(() => pool.freeBrowser(browser1)); |
There was a problem hiding this comment.
Тут нельзя await юзать. При limit:1 следующий второй getBrowser просто зависает с неразрезолвленным промисом пока предыдущий не освободится. Поэтому я тут вызываю без await и через 100ms 1ый браузер освободится. Второй браузер к этому моменту уже запрошен. В итоге в этом случае код попадет в тот участок, который я исправил и в котором была ошибка.
|
|
||
| this.log(`has queued requests for ${compositeId}`); | ||
| this.log(`remaining queue length: ${this._requestQueue.length}`); | ||
| this._newBrowser(queued.id, { version: queued.version }).then(queued.resolve, queued.reject); | ||
|
|
||
| this._newBrowser(queued.id, queued.opts).then(queued.resolve, queued.reject); |
There was a problem hiding this comment.
Проблема была в этой строке. Нужно было прокидывать все опции в которых летит state с testXReqId, а не только инфа о версии
DudaGod
force-pushed
the
HERMIONE-1336.fix_empty_x_req_id
branch
from
6c277e6
to
9b0bf6c
Compare
sipayRT
approved these changes
Feb 6, 2024
DudaGod
force-pushed
the
HERMIONE-1336.fix_empty_x_req_id
branch
from
9b0bf6c
to
5496a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.