Fix Dialyzer warnings #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires importing implicit dependencies, therefore a dedicated `dialyzer' rebar3 profile has been created.
Pointed out by these Dialyzer warnings:
209: The pattern {'ok', S} can never match the type binary()
227: The pattern {'ok', S} can never match the type binary()
Which are sensible - iconv:conv/2 returns `{ok,_}'.
…conv Revert this if and when eiconv merges the PR fixing Dialyzer analysis.
|
Are eiconv fixes submitted to upstream? If yes, can we wait untill they will be merged there and revert rebar.config changes? |
|
Also, it would be really great if some of the repo owners will add travis integration. I see there is already |
Yes, that was my stated intention :-) |
|
The eiconv fix has been merged upstream, and |
|
Thanks for the eiconv changes and this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socket:socket()typessl:socket()socket typeiconv:conv/2callThis is especially useful for library consumers, since some of the found issues would propagate all the way into them and sabotage proper static analysis.