Add LMTP as an option for the protocol implementation #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gen_smtp_server_session already aggregate all the recipients in a non empty list of strings, no extra checks are required.
This change in naming is compatible with the common jargon, and is also used in other softwares. For example, the mstmp client defines a `--protocol=smtp|lmtp` option (https://manpages.debian.org/testing/msmtp-mta/sendmail.8.en.html)
seriyps
requested changes
Mar 23, 2021
- Combine similar clauses of `gen_smtp_server_session:randle_request` for HELLO, EHLO and LHLO. - Move `report_recipient` and `queue_or_delivery` to the ends of their documents, so functions are defined "from top to down".
|
Thank you very much for the review @seriyps. This is also the first time I am working with LMTP, so I am not that experienced either. What I did was to follow RFC2033 and the recommendations of @Elemecca / @Shemeikka on #196. Maybe they have a bit more experience and could also have a look? To increase my confidence with the code, I did implement a quick experiment using OpenSMTPD to deliver local emails via LMTP to gen_smtp. |
Closed
mworrell
approved these changes
Apr 20, 2021
|
Merged! Thanks @abravalheri @mworrell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I would like to thank the maintainers for the amazing work and propose this PR as my attempt to add support for LMTP. This feature was requested in #196, and is something I find very appropriate, mainly because of the following reasons:
The implementation I attempted follow more or less the guidelines stablished in #196 and any suggestions for improvement are welcome (in fact this is my very first time writing something in Erlang, so still learning...).
I have also implemented a proof of concept/integration test using OpenSMTPD and docker in https://github.com/abravalheri/lmtp_poc, and things seem to work fine.
Unfortunately I was not able to think in an easy solution for optimising the separation of concerns without requiring duplication of code, but if the maintainers have any ideas and would like to guide me in the process, I am open to go through more iterations of this PR.