Don't crash SMTP client when TLS is optional and we failed to handshake #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`send_it` expects that `try_smtp_sessions` returns `{ok, Sock}`, but in
this scenario it would return just `Sock`.
|
So much for Dialyzer.... good catch! |
mworrell
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send_itexpects thattry_smtp_sessionsreturns{ok, Sock}, but in "restart without TLS" scenario it would return justSock.I'm quite surprized that Dialyzed did not complain.
This scenario have not been covered by tests, so, a new test was added.