gen_smtp_client: stop filtering gen_tcp and ssl options, fixes #271 #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tp#271 A lot of new useful options were added to gen_tcp and ssl in the recent OTP releases, but `smtp_socket` module (that backs gen_smtp_client) used to only allow a smal set of options and discarded all the not defined in the whitelist. We think that it's better to let programmer decide which options they want to pass - it should e programmer's responsibility if they provide invalid options.
seriyps
force-pushed
the
dont-filter-socket-options
branch
from
18f9563
to
3cfd421
Compare
mworrell
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of new useful options were added to gen_tcp and ssl in the recent
OTP releases, but
smtp_socketmodule (that backs gen_smtp_client) currentlyonly allows a smal set of options and discarded all the not defined in
the whitelist.
We think that it's better to let programmer decide which options they
want to pass - it should e programmer's responsibility if they provide
invalid options.
Especially given that we stopped doing any option filtering for gen_smtp_server after we migrated it to ranch.