Mimemail parameters fixes #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* only lowercase the pattern once * use `lists:search/2`
* fix bug when raw content-type params were returned instead of `parameters()` map * better `parameters()` validation in proper test
seriyps
commented
Jan 25, 2022
| @@ -143,9 +144,19 @@ decode(OrigHeaders, Body, Options) -> | |||
| decode_component(Headers, Body, MimeVersion, Options); | |||
| {<<"multipart">>, _SubType, _Parameters} -> | |||
| erlang:error(non_mime_multipart); | |||
| {Type, SubType, Parameters} -> | |||
| {Type, SubType, CTParameters} -> | |||
There was a problem hiding this comment.
the bug was here. We were returning the value of "content-type parameters" in place where we supposed to return mimemail:parameters() (combination of data extracted from content-type and content-disposition headers) map.
mworrell
approved these changes
Jan 25, 2022
|
Good work, thanks again! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that in some specific case
mimemail:mimetuple()'s 4th element which is supposed to always bemimemail:parameters()map, it is actually returned as a list (of incorrect values anyway) fromdecode/1.Fixed it, also added some more proper-tests validation for
parameters().Small bonus: some optimization in
mimemail:get_header_value/2,3