Throw permanent_failure when TLS fails due to non-started SSL. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it. |
|
Reading the code at that point, you might want to add |
|
Why ssl app wasn't started? I am starting server: |
|
@donpiekarz that's a good question, I guess. I ended up doing that in my app (which uses gen_smtp), but I didn't have to before. It seems to me gen_smtp should have started SSL, but for some reason it failed. This patch is only intended to improve the error message and ease debugging, though. |
|
@mworrell good catch, thanks! :-) |
|
Sorry for the enormous delay! :) |
arjan
pushed a commit
that referenced
this pull request
Jun 23, 2016
Arjan Scherpenisse (9):
'rebar3 hex cut' destroyed the .app.src formatting
Merge pull request #104 from tsloughter/master
Merge pull request #105 from tsloughter/now_deprecated
Remove old rebar.test.config
Merge pull request #71 from fdevibe/master
Fix #72
Fix link to OpenACD project
Merge pull request #106 from zambal/master
Remove unused nowarn_deprecated_function
Fredrik de Vibe (2):
Throw permanent_failure when TLS fails due to non-started SSL.
Close socket and send QUIT also when throwing error because SSL is not started.
Tristan Sloughter (2):
exclude smtp_rfc822_parse.erl from hex package
for 18+: remove use of now, replacing with unique_integer
Vincent Siliakus (1):
Fix -spec's for OTP-19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent a bit too much time debugging a temporary_failure, tls_failed error, only to find out that SSL wasn't started. I found this a bit misleading, hence this suggestion to clarify the cause of the failure. Also, I presume permanent_failure would be the correct error type, but I'm not really familiar with the code base, so there may well be better alternatives.