Ensure Unity publishing works without disrupting other targets #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes this problem: genaray/Arch#143 (reply in thread).
(However, note that tests for Arch.Extended were already failing before the Unity publishing changes were merged.)
Now the
TargetFrameworkfor projects that otherwise didn't have it is set tonet7.0which will prevent the tests from failing (for that reason).TargetFramework,TargetFrameworksandTargetFrameworkVersionare also now forced in theUnityPublish.shscript as arguments, because it 100% reliably overwrites whereas putting them inDirectory.Build.targetsapparently didn't. I'm not a fan of MSBuild.I'm additionally ensuring that any previously published assemblies are deleted before new ones are generated again just to be safe. We don't want old ones to gunk up the directory. And I removed some confusing language about codegen from the shell script. Sorry for all the hassle with this. It's a lot of trial and error wrangling this build system to comply with reason.
Edit: Sister PR: genaray/Arch#152