Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World concurrency fixes, structural change annotations, and code cleanup #156

Merged
merged 9 commits into from
Oct 27, 2023

Conversation

LilithSilver
Copy link
Contributor

  • Fixes some concurrency issues with World to make it thread-safe (outside of structural change and parallel query methods)
    • Of note, adds necessary locking mechanisms to World.Events.cs and world.Query() (the query caching behaviour)
  • Annotates structural changes with [StructuralChange] in World.cs
  • Annotates safe world extension methods with [WorldExtension]
  • Changes World API to officially support null class components through nullables, and fixes many (not all) nullable issues in the project
  • Makes Group<T0, ...>.Hash and .Types public
  • Minor improvements to documentation and code style based on the current .editorconfig, mostly focusing on World.cs
  • Compiler and intellisense warning fixes

Copy link
Owner

@genaray genaray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great job! :)

@genaray genaray merged commit 34104f7 into genaray:master Oct 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants