Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isConstraintsBatch loop not applying #2

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Fix isConstraintsBatch loop not applying #2

merged 1 commit into from
Apr 20, 2019

Conversation

Phenelo
Copy link
Contributor

@Phenelo Phenelo commented Apr 20, 2019

Track a flag (hasCreatedTable) for every schema that has been created successfully and only then it will be applied of its constraints to avoid errors of constraints already existing and for a clean table creation.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 18: 0.0%
Covered Lines: 557
Relevant Lines: 557
💛 - Coveralls

@genediazjr genediazjr merged commit dd2e684 into genediazjr:master Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Phenelo @coveralls @genediazjr