Use IPC::Run3::run3 rather than IPC::Open3::open3 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With IPC::Open3::open3 we can create deadlocks in two different situations: 1.) Git command writes more than a pipe buffer of data to stdout/stderr before reading stdin. 2.) Git command writes more than a pipe buffer of data to stderr before stdout. Solving this with Open3 involves dealing with select and a bunch of other messiness - let's just use IPC::Run3 which solves this problem already. Fixes issue #100
|
Merged manually; trial release coming soon. |
|
Hi @genehack! It would be really great if this patch was released to CPAN. Do you have any plans -- are there any other bugs that you wanted fixed before doing a full release? Just let us know if we can help 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With IPC::Open3::open3 we can create deadlocks in two different situations:
1.) Git command writes more than a pipe buffer of data to
stdout/stderr before reading stdin.
2.) Git command writes more than a pipe buffer of data to stderr
before stdout.
Solving this with Open3 involves dealing with select and a bunch of other
messiness - let's just use IPC::Run3 which solves this problem already.
Fixes issue #100