Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cellular processes in GO #12849

Open
ukemi opened this issue Dec 2, 2016 · 26 comments
Open

Refactor cellular processes in GO #12849

ukemi opened this issue Dec 2, 2016 · 26 comments

Comments

@ukemi
Copy link
Contributor

ukemi commented Dec 2, 2016

Currently in GO the definition of a cellular process is quite fuzzy:

Any process that is carried out at the cellular level, but not necessarily restricted to a single cell. For example, cell communication occurs among more than one cell, but occurs at the cellular level.

This definition makes it very difficult to formalize the meaning of this term and historically we have not necessarily created cellular versions of every process in GO and we have not always created generic processes for their cellular counterparts. This has become problematic over time. Most recently discussed in this ticket, #12721

There have been at least two proposals about how to deal with cellular processes which should be discussed.

  1. The distinction is not very relevant and we should merge the cellular terms into their generic parents. For those that do not have generic parents, change the terms to be more generic. This would mean that users will no longer be able to distinguish cellular from other levels of granularity. We have heard from at least a few users that they would like to be able to distinguish at this level.
  2. Make the distinction explicit. Define 'cellular process' as a process that occurs in a cell. This means that things like cell-cell communication, synaptic transmission etc would no longer be cellular processes. This split would be similar to the split between single-organism processes and multi-organism processes, however would not give us an advantage of adding a disjoint relation because some organisms are single cells.

Tagging for further comment.
@cmungall @hdrabkin @ukemi @dosumis @paolaroncaglia @mcourtot @tberardini @thomaspd @balhoff

@hdrabkin
Copy link
Contributor

hdrabkin commented Dec 2, 2016

"cell-cell communication, synaptic transmission"
But I would imagine that some parts of these processes are in fact cellular?

@dosumis
Copy link
Contributor

dosumis commented Dec 2, 2016

But I would imagine that some parts of these processes are in fact cellular?

Some parts occur in cells. But that's true of most BPs. I doubt that neurobiologists would care much or even notice if we don't classify synaptic transmission as 'cellular'.

@dosumis
Copy link
Contributor

dosumis commented Dec 2, 2016

One possible issue for occurs_in : import into cells - starts on the outside. Some of our axiomatization makes this explicit, which may cause problems at some point:

has_target_end_location o part_of -> has_target_end_location
occurs_in o part_of -> occurs_in

has_end_location
<- occurs in

Another possibility, reasonable clear but harder to axiomatize:

A process occurring in or involving exactly one cell.

@ukemi
Copy link
Contributor Author

ukemi commented Dec 2, 2016

Is there a way to express the cardinality of only one cell?

@cmungall
Copy link
Member

cmungall commented Dec 2, 2016 via email

@cmungall
Copy link
Member

cmungall commented Dec 2, 2016 via email

@balhoff
Copy link
Member

balhoff commented Dec 2, 2016

@cmungall can you point me to the "ELshunt pattern"? I couldn't find anything relevant with Google.

@cmungall
Copy link
Member

cmungall commented Dec 2, 2016 via email

@cmungall
Copy link
Member

cmungall commented Dec 3, 2016

See https://docs.google.com/document/d/1QpfUY_LgeIryMj6EEAE05FXLE_894GalkerBU8dMuVU/edit#

There have been at least two proposals about how to deal with cellular processes which should be discussed.

There is actually another possibility.

  1. Merge cellular X -> X
  2. Keep a high level CP class, define according to the doc (intuitively: something that can be represented in a LEGO model)
  3. Manually classify a handful of high level GO processes here: metabolism, ....

@thomaspd
Copy link
Contributor

thomaspd commented Dec 8, 2016

We discussed on ontology call, and we'd propose that cellular process (maybe clearer to rename it "cellular-level process" to distinguish from multicellular organism-level process) include both intracellular and intercellular processes. We don't need to add sub-classes for intracellular and intercellular processes, for the time being. But we can accept Chris's suggestion immediately above.

@ukemi
Copy link
Contributor Author

ukemi commented Dec 8, 2016

So I will rename the term. Do we want to do the merges as Chris suggests above? If we do that, very few classes will be at a cellular level. Clearly metabolism won't be one of them, but things like cell adhesion and cell-cell signaling will.

@dosumis
Copy link
Contributor

dosumis commented Dec 8, 2016

There is actually another possibility.

Merge cellular X -> X
Keep a high level CP class, define according to the doc (intuitively: something that can be > represented in a LEGO model)

??? Are there granularity limits to what we can put in a LEGO model?

Manually classify a handful of high level GO processes here: metabolism,

I predict TPV problems re-emerging regularly. Maybe OK if we can rely on Val to be semi-automated TPV detector?

@cmungall
Copy link
Member

cmungall commented Dec 8, 2016 via email

@cmungall
Copy link
Member

cmungall commented Dec 8, 2016 via email

@ValWood
Copy link
Contributor

ValWood commented Dec 8, 2016

I'm with Chris here. There should be a way to define all metabolism as cellular (I was trying to say this unsuccessfully in the previous ticket).
We know there are cases, like Peter's amino acid-liver example, where different cells perform part of a process at a tissue level. However, there is something fundamentally different about these processes which occur at the level of a single cell, and a process like behavior or development which clearly has parts which don't happen at a cellular level. I think we still haven't hit on the criteria to make this clear.

@ukemi do you have an example of a specific metabolism annotation which you think would seem odd annotated as a cell level process? Perhaps a hormone regulating a metabolic process (this still exerts it's effect in single cells so I wouldn't have a problem with this being cellular). Identifying some of the particular annotations of concern might help with the differentia for cell level.

@ValWood
Copy link
Contributor

ValWood commented Dec 13, 2016

Based on the eventual def, do you think that "protein localization" is also always a cellular process? can you think of any exceptions?

I also have a request. If we end up merging the any cellular/non-cellular terms, can we keep the more specific cellular term ID (not a problem if we can't but lots of our internal QC checks and curation config files are pinned to cellular terms).

@paolaroncaglia
Copy link
Collaborator

Hi @ValWood,

Re. “I also have a request. If we end up merging the any cellular/non-cellular terms, can we keep the more specific cellular term ID (not a problem if we can't but lots of our internal QC checks and curation config files are pinned to cellular terms).”
Unfortunately, in the very recent past merging terms and keeping the ID that should become secondary resulted in a Pandora’s box of downstream issues for various MODs (see #12729 and #12765 and). So I’m afraid we wouldn’t want to do that. Perhaps you could consider updating the PomBase internal QC checks and curation config files instead please, if we do go the merge route?

@ValWood
Copy link
Contributor

ValWood commented Dec 13, 2016

OK, we can do that, but we will need a list of all the merges posting here (probably should go to the GO list anyway as its a big change, whatever the resolution).
Although if the cellular distinction is preserved, the cellular and non-cellular term for most merges will have equivalent intended meaning, so the ID which is kept should be arbitrary?

pombase/curation#1221
pombase/canto#1292 (comment)

@paolaroncaglia
Copy link
Collaborator

@ValWood the issues were stemming exactly from keeping what should have been the secondary ID - in this sense, it is not arbitrary which ID we keep.
And yes, editors normally record details of merges on tickets. In this case, it might be advisable to copy the entire diff or save it as a file and attach it here (one can link to the online svn diffs, but they're usually very slow in loading).

@ValWood

This comment has been minimized.

@paolaroncaglia

This comment has been minimized.

@paolaroncaglia
Copy link
Collaborator

I'll be more precise: "so the ID which is kept should be arbitrary?" the ID which should be kept as primary is not arbitrary, and should be the one of the broader term; the ID of the narrower term, that will be merged into the broader term, will be kept as the secondary ID.

@ValWood
Copy link
Contributor

ValWood commented Dec 13, 2016

got it. although in the case of a merge they are presumably equivalent, so I don't fully understand it, but I will take your word for it;)

@ukemi ukemi moved this from Ontology meeting TBD to Ontology Call February 2, 2017 in ontology weekly meetings Jan 31, 2017
@ukemi ukemi moved this from Ontology Call February 9, 2017 to Ontology meeting TBD in ontology weekly meetings Feb 7, 2017
@ukemi ukemi moved this from Ontology meeting TBD to Ontology call March 31st 2017 in ontology weekly meetings Apr 6, 2017
@ukemi ukemi moved this from Ontology call April 7th, 2017 to Ontology call April 28th, 2017 in ontology weekly meetings Apr 27, 2017
@ukemi ukemi moved this from Ontology call April 28th, 2017 to Ontology call May 5, 2017 in ontology weekly meetings May 4, 2017
@vanaukenk vanaukenk moved this from Ontology call May 19, 2017 to Ontology call May 26, 2017 in ontology weekly meetings May 25, 2017
@vanaukenk vanaukenk removed this from Ontology call May 26, 2017 in ontology weekly meetings May 25, 2017
@vanaukenk vanaukenk added this to Ontology call May 26, 2017 in ontology weekly meetings May 25, 2017
@suzialeksander
Copy link
Contributor

@jimhu-tamu

@ukemi ukemi moved this from Ontology call May 26, 2017 to Ontology meeting TBD in ontology weekly meetings Jun 9, 2017
@cmungall cmungall changed the title cellular processes in GO Refactor cellular processes in GO Aug 29, 2018
@cmungall cmungall added this to To do in BP refactoring Aug 29, 2018
@cmungall
Copy link
Member

I would like to make some more progress on this.

Summarizing some previous docs

@pgaudet pgaudet moved this from Ontology meeting TBD to Done in ontology weekly meetings Aug 29, 2018
@pgaudet pgaudet moved this from Done to Ontology meeting week of September 10 in ontology weekly meetings Aug 29, 2018
@pgaudet
Copy link
Contributor

pgaudet commented Aug 29, 2018

I added this to the next ontology editors call.

@ukemi ukemi moved this from Ontology meeting week of September 10 to Ontology meeting Oct 1 in ontology weekly meetings Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
BP refactoring
  
To do
Development

No branches or pull requests

10 participants